🎨 Palette: Add real-time visual feedback to playbook execution#776
🎨 Palette: Add real-time visual feedback to playbook execution#776
Conversation
Co-authored-by: dolagoartur <146357947+dolagoartur@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5e73314806
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let mut step_mode = self.config.step; | ||
|
|
||
| for task in tasks { | ||
| self.emit_event(ExecutionEvent::TaskStartGlobal(task.name.clone())); |
There was a problem hiding this comment.
Emit global task-start only for runnable tasks
TaskStartGlobal is emitted before host filtering, so callbacks now report TASK [...] even when the task never runs (for example when active_hosts is empty because all hosts already failed, or block-state filtering skips that task and the loop continues/breaks). This makes the new real-time output inaccurate and can leave users with task headers that have no corresponding results; move the emit to after the active_hosts.is_empty() guard (and after any step-mode skip decisions) so the event means execution actually started.
Useful? React with 👍 / 👎.
💡 What: Added real-time visual feedback to the
rustible runcommand by hooking theExecutor's event stream to the CLIOutputFormatter.🎯 Why: Previously,
rustible runwas silent by default (relying ontracinglogs which are hidden at default verbosity), providing no feedback until the final recap. Users couldn't see which task was running or the result of individual tasks.📸 Before/After:
♿ Accessibility: Output is buffered to ensure atomic line printing, preventing interleaved/garbled text when tasks complete in parallel, ensuring screen readers (and humans) can read complete lines.
PR created automatically by Jules for task 13989062477542473043 started by @dolagoartur