ci: gate major optional feature bundles in test matrix#793
ci: gate major optional feature bundles in test matrix#793
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ad2988c9da
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| run: cargo check --all-targets --features "${{ matrix.bundle.features }}" --verbose | ||
|
|
||
| - name: Run bundle tests | ||
| if: matrix.bundle.mode == 'test' | ||
| run: cargo test --lib --features "${{ matrix.bundle.features }}" --verbose -- --test-threads=1 |
There was a problem hiding this comment.
The new bundle gate is described as catching regressions "outside the default profile," but these commands only pass --features; per cargo test -h, default features remain active unless --no-default-features is set. That means each matrix row still compiles/tests with the default russh,local set enabled, so regressions that appear when consumers build a bundle without defaults (for example --no-default-features --features api) will not be detected by this CI job.
Useful? React with 👍 / 👎.
1 participant
Closes #791.