ci: automate high-risk suite validation for beta sign-off#796
ci: automate high-risk suite validation for beta sign-off#796
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a305733217
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if ! [[ "$proptest_cases" =~ ^[0-9]+$ ]]; then | ||
| echo "::error::proptest_cases must be a positive integer, got '$proptest_cases'" |
There was a problem hiding this comment.
Disallow zero PROPTEST_CASES in profile validation
The input validation accepts proptest_cases=0 because it only checks for digits, but that value is later forwarded to PROPTEST_CASES in the fuzz job, which lets proptest run zero generated cases and still report success. In a workflow_dispatch or workflow_call run, this can let beta sign-off pass with effectively no fuzz coverage, which defeats the purpose of this workflow; require a strictly positive value (e.g., ^[1-9][0-9]*$) before writing the output.
Useful? React with 👍 / 👎.
Summary
scheduled-smokeandbeta-signoff) with explicit smoke/full reportingCloses #792