🎨 Palette: Improve interactive file selection UX#800
Conversation
…tilde expansion - Add `✏️ Enter custom path...` option to `select_playbook` - Implement path existence validation for both inventory and playbook custom inputs - Use `shellexpand::tilde` to support `~/` home directory expansion in interactive inputs - Improve "No playbooks found" UX by prompting for manual entry instead of returning immediately - Update imports in `src/cli/interactive.rs` to include `Path` Co-authored-by: dolagoartur <146357947+dolagoartur@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b1fe6527b6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if path.exists() { | ||
| Ok(()) |
There was a problem hiding this comment.
The new custom playbook validator accepts any existing path via Path::exists(), which also returns true for directories; this lets users submit a directory from interactive mode and only fail later when playbook loading/parsing runs, so the prompt no longer provides the immediate validation it intends to provide. This is reproducible whenever the custom path points to an existing directory (for example . or playbooks/).
Useful? React with 👍 / 👎.
1 participant
This PR enhances the interactive mode UX (
src/cli/interactive.rs) by adding proper validation and usability improvements for file selection.Changes:
playbooks/folder.shellexpand::tildeto support~/path/to/filesyntax in interactive prompts, which is a standard and expected shell behavior.UX Improvements:
Testing:
cargo checkpasses.Path::exists()andshellexpandwhich are reliable.PR created automatically by Jules for task 11580466807717561149 started by @dolagoartur