refactor(encryption): migrate to @boringnode/encryption#109
refactor(encryption): migrate to @boringnode/encryption#109RomainLanz wants to merge 0 commit into8.xfrom
Conversation
One would still be able to create a custom verifier though? |
|
We had an internal discussion with Aman on this topic. After some consideration, we decided to keep the Instead, the package will expose the |
6372594 to
d25731b
Compare
Hey! 👋🏻
This is the first PR to migrate from the AdonisJS encryption module to
@boringnode/encryption.@boringnode/encryptionprovides support for multiple encryption algorithms and a proper key rotation strategy.Regarding message signing and verification: I started looking at the
MessageVerifierthat currently lives inside the encryption module. It might make more sense to move it into the core module instead, and rely on a singleSIGN_KEYvalue in the core (app.tsconfiguration file). That way, we wouldn't need to instantiate aMessageVerifierfor every key used by the encryption module.For context: I'm not using the encryption module
MessageVerifierdirectly. Only the legacy encryption driver inside the core currently makes use of it (and other part of the framework).