add wildcard support for route matching#110
Closed
ilsyaa wants to merge 2 commits intoadonisjs:8.xfrom
Closed
Conversation
Member
|
Hey @ilsyaa! 👋🏻 Thanks for the PR! 🎉 What would be the usecase for this feature? |
Member
|
Hello @ilsyaa Sorry, if I wasn't clear. I meant we should support the route names and not the wildcard, because the regex based matching will have a mismatch between the actual route matching logic and this method. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❓ Type of change
📚 Description
✨ Added Wildcard Support to
matchesRouteThis feature introduces wildcard (
*) matching support to thematchesRoutemethod.Developers can now use conventions like
admin.users*to match multiple routes based on a common prefix, similar to wildcard matching in other frameworks like Laravel.How it works:
*, it is treated as a regular expression pattern.*is converted to.*(match zero or more characters)..) is escaped to treat it as a literal dot (\\.).route.nameandroute.pattern.Example:
admin.users.*will matchadmin.users.index,admin.users.create, etc.api.*.showwill matchapi.posts.show,api.comments.show, etc.📝 Checklist