Skip to content

Conversation

@marcuspoehls
Copy link
Contributor

🔗 Linked issue

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This merge request adds a return this to all assertion methods within the MailsCollection class. This mail collection class is returned from the fake mailer. Returning the same instance allows chaining of assertsions.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.
  • I feel like there’s no documentation needed for this change.

@thetutlage
Copy link
Member

Looks good to me!

@thetutlage thetutlage merged commit 0b12570 into adonisjs:10.x Jan 17, 2026
1 of 3 checks passed
@marcuspoehls
Copy link
Contributor Author

Cool! Are you interested in bringing this to the 9.x branch? I'm using still using mail 9.x and as Adonis v7 is approaching, we may skip backporting this change. It just depends on the timeline of the next major launch

@thetutlage
Copy link
Member

Hello @marcuspoehls

I think we can backport it to 9.x as well.

@marcuspoehls marcuspoehls deleted the return-this-in-mailscollection-assert-methods branch January 19, 2026 08:17
@marcuspoehls
Copy link
Contributor Author

@thetutlage Then I’m preparing another pull request for the 9.x branch. It’s coming today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants