-
-
Notifications
You must be signed in to change notification settings - Fork 79
linux libfreetype dependencies broken in jdk 8-20 #1318 #1319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linux libfreetype dependencies broken in jdk 8-20 #1318 #1319
Conversation
Removed removal of freetype from all linux temurin installer files. Not toouching dragonwell and miscrosoft for now - no idea how they build.
|
@steelhead31 as currently is running first release with in-tree freetype everywhere, maybe this shoudl go over freez exception.... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.
If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.
If the code freeze is over you can remove this block by commenting /thaw.
|
@karianna if Microsoft (and well also dragonwell) are using vanilla/temruin build, then I'm ok to clear theirs specfiles too. |
Yes, I think this might be important to get in for this release, we've already shipped a few packages, so we'd need to provide updates.. I'll run a few tests... |
steelhead31
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
|
I've done some local testing with these changes, and im happy with the results. |
|
/merge |
|
Approval to merge during the lockdown cycle Please can two Adoptium PMC members comment |
|
/approve |
|
/approve |
Thank you @steelhead31 and @andrew-m-leonard for your approvals, this pull request is now approved to merge during release.
|
Whoosh that was quick. Tahnx a lot. I hope it is as good as I consider it. @steelhead31 Thanx a lot for additional testing!!! |
fixing #1318
Removed removal of freetype from all linux temurin installer files. Not toouching dragonwell and miscrosoft for now - no idea how they build.