Allow to cancel optimization from cost & constraint functions#19
Open
gollth wants to merge 1 commit intoadwhit:masterfrom
Open
Allow to cancel optimization from cost & constraint functions#19gollth wants to merge 1 commit intoadwhit:masterfrom
gollth wants to merge 1 commit intoadwhit:masterfrom
Conversation
gollth
force-pushed
the
usable-force-stop
branch
from
020ea59 to
7c1a97c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing the problem in #11
I need this feature for a project, so thought I'll give it a shot. I went with this
trait Terminationstyle approach suggested in the issue and implemented it forf64, so that there are no breaking changes to user code. However now users can returnResults from cost & constraint functions, to let the optimization gracefully stop.Note also that the
S: Terminationin the constraints function is different from theR: Terminationfrom the cost function, so that users can only cancel in one of the two, or with different error types even.Let me know what you thing (=