fix: use correct namespace for leader election #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m namespace Signed-off-by: Pascal Iske <info@pascaliske.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when the operator is deployed into a custom namespace the leader election does not work because of a hard-coded default value for the
LeaderElectionNamespace:cloudflare-operator/cmd/main.go
Line 79 in da0c5f0
In fact the Kubebuilder book FAQs recommend to set the field only in non-cluster deployments for development purposes: https://book.kubebuilder.io/faq#after-make-run-i-see-errors-like-unable-to-find-leader-election-namespace-not-running-in-cluster
As an easy fix the default value could be removed.