Split txn #25
Merged
Split txn #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Whoops, missed this MR. Will get to it this week! |
Contributor
Author
Good thing you did, the amount of bugs I found when trying to run it for my account was unbelievable lol :) Major functional change: SW balance transfers are uncategorized by default now. It makes more sense when looking at the "Groceries" category to see only the txns which are my share, and not the balancing deposit txns into the SW balance. |
Contributor
Author
|
ping |
Owner
|
Perfect, lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fully solves #9.
Notes:
addTransaction: extended signature to acceptgroup_titlefor split transactions since it made sense to me, but I don't use it in the implementation. Seems useful for the future.