bugfix: updating split transactions #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adyanth
reviewed
Mar 15, 2025
Comment on lines
+246
to
+251
| if len(newTxns) > 1: | ||
| # order lists so that the first element is the one that is not the balance account transaction | ||
| cover_new = [txn for txn in newTxns if txn['description'].startswith('Cover for:')] | ||
| cover_old = [txn for txn in oldTxns if txn['description'].startswith('Cover for:')] | ||
| newTxns = [txn for txn in newTxns if not txn['description'].startswith('Cover for:')] + cover_new | ||
| oldTxns = [txn for txn in oldTxns if not txn['description'].startswith('Cover for:')] + cover_old |
Owner
There was a problem hiding this comment.
This does not seem like the best way to do this, but it is faster than sorting, so I am fine with it.
Owner
|
thanks, I missed this, merging now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
updateTransactionmethod was not set up to handle split transactions, which occur with the new debt tracking functionality.This PR modifies
updateTransactionto handle such cases by handling list inputs (representing splits), aligning them according to the real and cover splits by identifying the transaction whose description starts with "Cover for:", and then proceeds to update the fields as for a regular transaction.