Fix ExtendedPlayerInventory poor performance #122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
ExtendedPlayerInventory tanks client performance.
This was due to constant exception handling (Null Pointer Exception).
This commit has no intended functional changes other than adding null pointer checks where the constant null pointer exception handling was occuring.
The unintended functional change is the v, b, n UI moves from the center of the screen (which I do not believe is by design), to the left of the screen, vertically centered (see screenshots below).
I can provide more version, mod details if needed, but given the safety of these changes, I don't find it necessary.
Testing
Before:
After:
(Errors no longer spamming the logs)