Skip to content

Conversation

@ActuallyAdasi
Copy link

Background

ExtendedPlayerInventory tanks client performance.

This was due to constant exception handling (Null Pointer Exception).

This commit has no intended functional changes other than adding null pointer checks where the constant null pointer exception handling was occuring.

The unintended functional change is the v, b, n UI moves from the center of the screen (which I do not believe is by design), to the left of the screen, vertically centered (see screenshots below).

I can provide more version, mod details if needed, but given the safety of these changes, I don't find it necessary.

Testing

Before:

image

image

After:

(Errors no longer spamming the logs)

[Info   : Unity Log] ExtendedPlayerInventory InventoryGui Show
[Info   : Unity Log] 03/22/2025 12:57:23: Setting selected recipe 0

[Info   : Unity Log] ExtendedPlayerInventory InventoryGui Show

image

This was due to constant exception handling (Null Pointer Exception).

This commit has no functional changes other than adding null pointer
checks where the constant null pointer exception handling was occuring.
@ActuallyAdasi
Copy link
Author

Let me know if I can take steps to release this on r2modman as well, right now I'm just sharing the resulting dll with the players in my server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant