Conversation
timkim
reviewed
Jan 6, 2026
Collaborator
timkim
left a comment
timkim
left a comment
There was a problem hiding this comment.
I think we only want to set these if it's in local dev mode. I have a bit of code here:
devsite-runtime-connector/src/index.ts
Line 55 in a31bbf6
that shows how I'm detecting local dev mode. I think we want to ensure we only set cors response when in local dev. Not sure what would happen if we set it and left it on.
timkim
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding cors origin for localhost to run from localhost:3000 to call localhost:3002.