Scripts.js maintenance: sanitizeHTML and reduce function complexities#676
Merged
helms-charity merged 4 commits intomainfrom Feb 23, 2026
Merged
Scripts.js maintenance: sanitizeHTML and reduce function complexities#676helms-charity merged 4 commits intomainfrom
helms-charity merged 4 commits intomainfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The biggest change was that
handleSectionMetadatawas reduced from a complexity of 41 to under 15 by moving logic into five helpers:Also added the section metadata key lists as Set()s since apparently this has been a thing since ES6.
Fix #675
Test URLs:
Before: https://main--idfc--aemsites.aem.page/
After: https://675-scriptsjsmain--idfc--aemsites.aem.page/
Before: https://main--idfc--aemsites.aem.page/credit-card/metal-credit-card/mayura
After: https://675-scriptsjsmain--idfc--aemsites.aem.page/credit-card/metal-credit-card/mayura
Testing: There should not be any functional difference.