Skip to content

Comments

adding sonarJS to our ESLint to evaluate it#681

Merged
helms-charity merged 3 commits intomainfrom
680-sonarjs
Feb 22, 2026
Merged

adding sonarJS to our ESLint to evaluate it#681
helms-charity merged 3 commits intomainfrom
680-sonarjs

Conversation

@helms-charity
Copy link
Collaborator

@helms-charity helms-charity commented Feb 22, 2026

Sonarjs
First I tested adding the SonarQube extension to Cursor (formerly SonarLint, which I used in previous AEM maven projects). It is very verbose and opinionated in what it checks (and I found some false positives) so filtering by 'high severity' was helpful.

But then I realized SonarJS as an ESlint plugin existed, which I am adding here. It is closer to finding the things I expected. (rules: https://github.com/SonarSource/SonarJS/blob/master/packages/jsts/src/rules/README.md#rules but they are different than what SonarQube found, and I'm not seeing any non-sanitized inner.HTML being flagged for XSS.

update package.json and package-lock.json
I noticed our versions of some items weren't updated with the latest Xwalk boilerplate repo, so I updated those too.

update README.md
I added a mention of the sonarJS and also a troubleshooting step to fix broken stylelint rules config.

remove old buttons test.html file
Fix #680

Test URLs:

@aem-code-sync
Copy link

aem-code-sync bot commented Feb 22, 2026

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync
Copy link

aem-code-sync bot commented Feb 22, 2026

Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync aem-code-sync bot temporarily deployed to 680-sonarjs February 22, 2026 13:31 Inactive
@helms-charity helms-charity merged commit 353c0ba into main Feb 22, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add SonarJS plugin for ESLint

1 participant