adding sonarJS to our ESLint to evaluate it#681
Merged
helms-charity merged 3 commits intomainfrom Feb 22, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sonarjs
First I tested adding the SonarQube extension to Cursor (formerly SonarLint, which I used in previous AEM maven projects). It is very verbose and opinionated in what it checks (and I found some false positives) so filtering by 'high severity' was helpful.
But then I realized SonarJS as an ESlint plugin existed, which I am adding here. It is closer to finding the things I expected. (rules: https://github.com/SonarSource/SonarJS/blob/master/packages/jsts/src/rules/README.md#rules but they are different than what SonarQube found, and I'm not seeing any non-sanitized
inner.HTMLbeing flagged for XSS.update package.json and package-lock.json
I noticed our versions of some items weren't updated with the latest Xwalk boilerplate repo, so I updated those too.
update README.md
I added a mention of the sonarJS and also a troubleshooting step to fix broken stylelint rules config.
remove old buttons test.html file
Fix #680
Test URLs: