Skip to content

cc-hero-slider.js santizeHTML for XSS #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
helms-charity wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

cc-hero-slider.js santizeHTML for XSS #686

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions blocks/cc-hero-slider/cc-hero-slider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { loadScript, loadCSS } from '../../scripts/aem.js';
import { moveInstrumentation } from '../../scripts/scripts.js';
import { moveInstrumentation, sanitizeHTML } from '../../scripts/scripts.js';

/**
* Decorates the CC Hero Slider block
Expand Down Expand Up @@ -58,16 +58,16 @@ export default async function decorate(block) {

// Fourth div: Pop-up trigger CTA text (optional)
const popupTriggerDiv = children[3];
if (popupTriggerDiv && popupTriggerDiv.textContent.trim()) {
if (popupTriggerDiv?.textContent.trim()) {
const popupTrigger = document.createElement('div');
popupTrigger.className = 'cc-hero-slider-popup-trigger';
popupTrigger.innerHTML = popupTriggerDiv.innerHTML;
popupTrigger.innerHTML = sanitizeHTML(popupTriggerDiv.innerHTML);
swiperSlide.appendChild(popupTrigger);
}

// Fifth div: Pop-up ID (optional) - store as data attribute
const popupIdDiv = children[4];
if (popupIdDiv && popupIdDiv.textContent.trim()) {
if (popupIdDiv?.textContent.trim()) {
swiperSlide.dataset.popupId = popupIdDiv.textContent.trim();
}

Expand Down
Loading