Skip to content

Embed.js: added sanitizeHTML from DOMpurity #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
helms-charity merged 1 commit into from
Feb 23, 2026
Merged

Embed.js: added sanitizeHTML from DOMpurity #688

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions blocks/embed/embed.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@
* https://www.hlx.live/developer/block-collection/embed
*/

import { sanitizeHTML } from '../../scripts/scripts.js';

/* eslint-disable secure-coding/no-improper-sanitization --
sanitizeHTML uses DOMPurify via the import from scripts.js which linting can't see */

const loadScript = (url, callback, type) => {
const head = document.querySelector('head');
const script = document.createElement('script');
Expand Down Expand Up @@ -80,10 +85,10 @@ const loadEmbed = (block, link, autoplay) => {
const config = EMBEDS_CONFIG.find((e) => e.match.some((match) => link.includes(match)));
const url = new URL(link);
if (config) {
block.innerHTML = config.embed(url, autoplay);
block.innerHTML = sanitizeHTML(config.embed(url, autoplay));
block.classList = `block embed embed-${config.match[0]}`;
} else {
block.innerHTML = getDefaultEmbed(url);
block.innerHTML = sanitizeHTML(getDefaultEmbed(url));
block.classList = 'block embed';
}
block.classList.add('embed-is-loaded');
Expand All @@ -97,7 +102,7 @@ export default function decorate(block) {
if (placeholder) {
const wrapper = document.createElement('div');
wrapper.className = 'embed-placeholder';
wrapper.innerHTML = '<div class="embed-placeholder-play"><button type="button" title="Play"></button></div>';
wrapper.innerHTML = sanitizeHTML('<div class="embed-placeholder-play"><button type="button" title="Play"></button></div>');
wrapper.prepend(placeholder);
wrapper.addEventListener('click', () => {
loadEmbed(block, link, true);
Expand Down
Loading