Skip to content

Comments

feat: upgrade rum to v2#616

Open
shsteimer wants to merge 5 commits intomainfrom
rum-v2
Open

feat: upgrade rum to v2#616
shsteimer wants to merge 5 commits intomainfrom
rum-v2

Conversation

@shsteimer
Copy link

@shsteimer shsteimer commented Dec 10, 2024

@aem-code-sync
Copy link

aem-code-sync bot commented Dec 10, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@shsteimer shsteimer marked this pull request as ready for review December 10, 2024 16:21
@aem-code-sync
Copy link

aem-code-sync bot commented Dec 10, 2024

Page Scores Audits Google
📱 /en-us?rum=on PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /en-us?rum=on PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@kronnox
Copy link
Collaborator

kronnox commented Dec 10, 2024

@shsteimer Is this a drop in replacement or will we need to adjust something else? Also, is there a changelog / documentation on what was changed between the version?

@shsteimer
Copy link
Author

@shsteimer Is this a drop in replacement or will we need to adjust something else? Also, is there a changelog / documentation on what was changed between the version?

should not require you to do anything other than what is in the PR. Would obviously encourage you to verify it doesn't break anything, but these are all changes that are in the current version of AEM boilerplate, so should be safe.

Mainly this is about moving you to v2 of the rum enhancer, see https://github.com/adobe/helix-rum-enhancer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants