Skip to content

Comments

Assesibility fix for the header [Do Not Merge]#720

Open
jindaliiita wants to merge 4 commits intomainfrom
a-fix
Open

Assesibility fix for the header [Do Not Merge]#720
jindaliiita wants to merge 4 commits intomainfrom
a-fix

Conversation

@jindaliiita
Copy link
Collaborator

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix

Test URLs:

@aem-code-sync
Copy link

aem-code-sync bot commented Jan 21, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync
Copy link

aem-code-sync bot commented Jan 21, 2025

Page Scores Audits Google
📱 /en-us/about PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /en-us/about PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Collaborator

@kronnox kronnox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks the search button. The links can't have an href. TBH semantically this probably should be buttons and not anchors anyway

@jindaliiita
Copy link
Collaborator Author

This breaks the search button. The links can't have an href. TBH semantically this probably should be buttons and not anchors anyway

Can you please check now, I earlier checked only that search popup is opening or not. Now for me functionality is also working fine

@kronnox
Copy link
Collaborator

kronnox commented Jan 22, 2025

@jindaliiita Not sure if it's a caching issue or something but the search is still not working for me. Maybe it needs to be a submit button after all

@jindaliiita jindaliiita changed the title Assesibility fix for the header Assesibility fix for the header [Do Not Merge] Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants