Listen for bfcache pageshow event and reset add to cart button if needed#226
Open
dylandepass wants to merge 6 commits intomainfrom
Open
Listen for bfcache pageshow event and reset add to cart button if needed#226dylandepass wants to merge 6 commits intomainfrom
dylandepass wants to merge 6 commits intomainfrom
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
dylandepass
changed the title
|
Contributor
Author
|
/run-tests |
|
❌ Integration tests failed. 🔍 Check the workflow run for details |
Contributor
Author
|
/run-tests |
|
✅ Integration tests passed! 🎉 All Playwright tests completed successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently after the a product is added to the cart we re-enable the "Add to Cart" just after navigating to the cart page. The problem is it takes awhile to load the navigation page so users are seeing the "Add to Cart" button re-enabled before the cart page is loaded.
This PR only attempts to only re-enable the add to cart button if the page is restored from the bfcache.
Test URLs: