-
Notifications
You must be signed in to change notification settings - Fork 6
Add aep.api.resource annotation for resource definitions #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: toumorokoshi <391240+toumorokoshi@users.noreply.github.com>
Co-authored-by: toumorokoshi <391240+toumorokoshi@users.noreply.github.com>
toumorokoshi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! please see comments, getting close.
Co-authored-by: toumorokoshi <391240+toumorokoshi@users.noreply.github.com>
Co-authored-by: toumorokoshi <391240+toumorokoshi@users.noreply.github.com>
Co-authored-by: toumorokoshi <391240+toumorokoshi@users.noreply.github.com>
|
@rambleraptor I think we have one more proto annotation we need add for ourselves 😅 . Can you take a look? |
toumorokoshi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
rambleraptor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me. We'll need to make the corresponding linter changes as well
agreed! Is something you can take on @rambleraptor ? |
Adds
aep.api.resourceproto annotation similar togoogle.api.resource, enabling resource metadata definition with AEP-specific extensions.Changes
proto/aep-api/aep/api/resource.protoResourceDescriptormessage with fields:type,pattern(repeated),singular,plural,parent(repeated)google.protobuf.MessageOptions(ID: 1266)parentfield allows specifying multiple parent resource types in singular form_idsuffix convention (e.g.,{project_id},{topic_id})Usage
Subset of google.api.resource fields chosen per issue requirements. Extension ID 1266 from registered aep.dev range (1264-1274).
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.