feat(x-aep-field): add field number #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
field numbers are not officially required by the AEPs, but are useful for enumeration in intermediary representations such as resource definitions for aep-lib-go.
rambleraptor
approved these changes
Nov 11, 2025
Member
rambleraptor
left a comment
rambleraptor
left a comment
There was a problem hiding this comment.
I'm still trying to wrap my head around when you would want this if you don't have a proto-based API, but I don't want to block
Member
Author
yeah, that's why it's explicitly noted as a field that isn't official in the aep spec yet. the examples will still have it removed in aep.dev to minimize confusion. FWIW it's not just protobuf that uses field numbers, there are also systems like thrift. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
field numbers are not officially required by the AEPs, but are useful for enumeration in intermediary representations such as resource definitions for aep-lib-go.