feat(0004): clarify resource names requirements #397
Merged
+6
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A requirement stated that only alphanumerics were allowed, conflicting with a line later that also allowed kebab-cased dashes. Clarifying that dashes are indeed allowed. fixes aep-dev#396
mkistler
requested changes
Dec 12, 2025
Contributor
mkistler
left a comment
mkistler
left a comment
There was a problem hiding this comment.
Probably should fix this
Contributor
|
Sorry ... one more thing. Should there be a It looks like the example.oas.yaml includes If it's valid, I think we need to describe it in AEP-004. |
Co-authored-by: Mike Kistler <mkistler@sbcglobal.net>
Member
Author
I agree, although a part of me thinks that should be a separate, granular change? No strong opinion though so i suppose I should just add it. |
Member
|
Are we back porting this? |
toumorokoshi
force-pushed
the
yft/fix-396
branch
from
6411cf5 to
2922d11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A requirement stated that only alphanumerics were allowed, conflicting with a line later that also allowed kebab-cased dashes.
Clarifying that dashes are indeed allowed.
fixes #396
🍱 Types of changes
What types of changes does your code introduce to AEP? Put an
xin the boxesthat apply
📋 Your checklist for this pull request
Please review the AEP Style and Guidance for
contributing to this repository.
General
references AEPs
correctly.
(run
make lint)💝 Thank you!