Use aep.api.resource instead of google.api.resource #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toumorokoshi
requested changes
Nov 10, 2025
Member
toumorokoshi
left a comment
toumorokoshi
left a comment
There was a problem hiding this comment.
thanks! looks good overall, just one question on file-level resource annotations.
Also CI is failing, looks like it wouldn't compile as well.
Member
|
Also: do we have an e2e test that runs the linter rules on the aep example proto. If not, maybe we can add one? That would help with catching any regressions (since we generally updated the example after the linter fixes). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This swaps out
google.api.resourceforaep.api.resourcein docs/tests/code.