Skip to content

Conversation

@Archfx
Copy link

@Archfx Archfx commented Mar 26, 2019

Multiple decimal point issue is fixed now. Only accepts the initial decimal point others are ignored.
recognizing the initial ".X" as "X." is fixed now. Now it takes the value as "0.X"

Multiple decimal point issue is fixed now. Only accepts the initial decimal point others are ignored.
recognizing the initial ".X" as "X." is fixed now. Now it takes the value as "0.X"
@Alii-Khaled
Copy link
Contributor

Alii-Khaled commented Mar 27, 2019

I think it would be better to make the fix in a place where it works well for both CLI & GUI and also to prevent the user from making any decisions till he keeps only 1 decimal point. am i right@8hantanu ?!!

@Archfx
Copy link
Author

Archfx commented Mar 28, 2019

I think it would be better to make the fix in a place where it works well for both CLI & GUI and also to prevent the user from making any decisions till he keeps only 1 decimal point. am I right@8hantanu ?!!

I think input validation and restricting invalid inputs should be done at GUI level. Because in CLI we don't have other option rather than handling an exception.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants