Adopt new OpenTelemetry HTTP attribute names#202
Open
istathar wants to merge 2 commits intoaesiniath:mainfrom
Open
Adopt new OpenTelemetry HTTP attribute names#202istathar wants to merge 2 commits intoaesiniath:mainfrom
istathar wants to merge 2 commits intoaesiniath:mainfrom
Conversation
istathar
added
the
core-webserver
pasunboneleve
approved these changes
Dec 18, 2023
Contributor
pasunboneleve
left a comment
pasunboneleve
left a comment
There was a problem hiding this comment.
This looks good, but I miss tests (or a mention that you tested it live).
Member
Author
|
I agree this part of the codebase needs a proper test harness. I ran tests/WarpSnippet locally with |
Contributor
|
Maybe see if Publish sends the data properly to Honeycomb? You need proof their server understands the data you'll be sending too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As announced at https://www.honeycomb.io/blog/opentelemetry-http-attributes, OpenTelemetry is addopting new stabilized attribute names for HTTP factors. This branch updates the field names sent by Core.Webserver.Warp for requests and responses.