Skip to content

ensure calls to .sample() are deterministic in CI #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
afeld wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ensure calls to .sample() are deterministic in CI #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bf9f3d
ensure calls to .sample() are deterministic in CI
afeld Nov 5, 2020
593fa88
exclude sample output
afeld Jan 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
# - hw_4.ipynb # has incomplete code
- hw_5.ipynb
- lecture_0.ipynb
# - lecture_1.ipynb # uses sample()
- lecture_1.ipynb
- lecture_2.ipynb
- lecture_3.ipynb
- lecture_4.ipynb
Expand Down
4 changes: 4 additions & 0 deletions scripts/diffable.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@ def has_html_output(output):
if cell["source"][0].startswith("!"):
cell["outputs"] = []

# ignore sample() output
if any(".sample(" in line for line in cell["source"]):
cell["outputs"] = []

# filter out pip upgrade warnings
cell["outputs"] = [line for line in cell["outputs"] if not is_pip_upgrade_msg(line)]

Expand Down