Conversation
zibrov-zlobin
requested changes
Apr 21, 2018
Member
zibrov-zlobin
left a comment
zibrov-zlobin
left a comment
There was a problem hiding this comment.
Some of the comment boxes still need work.
e.g. "update acbox values" - what values?
"sets channel voltage" should be sets [voltage]
"Sets phase between boards" needs to reflect which boards as "Sets the phase between the X1 and X2. The phase between X1 and Y1 is always 90 degrees.
Also make sure it indicates what the value is - is the phase in degrees, is the phase in radians, what is the positive phase, what is the negative phase?
Set frequency - sets the frequency and not "cannot exceed"
get_voltage reads voltage or returns the set voltage?
some functions need examples, most importantly buffer ramp.
everything else is along the same lines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comments for DACs,ACs,and DAC-ADC.