Skip to content

Login & register form error message position done#101

Open
Pushpendra33 wants to merge 7 commits intoagamjotsingh18:mainfrom
Pushpendra33:formFunctionalitiesByPushpendra33
Open

Login & register form error message position done#101
Pushpendra33 wants to merge 7 commits intoagamjotsingh18:mainfrom
Pushpendra33:formFunctionalitiesByPushpendra33

Conversation

@Pushpendra33
Copy link

@Pushpendra33 Pushpendra33 commented May 24, 2023

Pull Request Template

Login and register form error message positions correction done

Description

i have changed the position of toast messages for email and password in login and register

Fixes # (issue)
#90

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested on my local machine properly

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@vercel
Copy link

vercel bot commented May 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pollitup ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 26, 2023 6:12am

@netlify
Copy link

netlify bot commented May 24, 2023

Deploy Preview for pollitup failed.

Name Link
🔨 Latest commit 2f15212
🔍 Latest deploy log https://app.netlify.com/sites/pollitup/deploys/646e0909f6131000076b5d6c

@Arnabdaz
Copy link
Collaborator

@Pushpendra33 please remove package-lock.json from your pr

@Pushpendra33
Copy link
Author

Pushpendra33 commented May 24, 2023

@Pushpendra33 please remove package-lock.json from your pr

please check latest PR, i have removed package-lock.json file

@Arnabdaz
Copy link
Collaborator

please use single quotes in prettier config and don't add the package.json and package-lock.json changes to your pr ... only add the changes mentioned for this pr

Pushpendra Singh added 2 commits May 26, 2023 11:38
@Arnabdaz
Copy link
Collaborator

@Pushpendra33 remove .gitignore from the pr and use single quotes instead of double quotes in the files you changed ... you can change the settings / configuration for this from vs code settings or prettier config file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

login and register form validation and error message [Development and correction] GSSOC'23

2 participants