Fix Citation serialization issue causing truncated JSON files #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace asdict() with manual dict conversion in JobResult.to_dict() - Fix both citations and citation_mappings serialization - Resolves TypeError: Object of type Citation is not JSON serializable - Ensures complete job output files instead of truncated ones - Tested with comprehensive verification script
- Test specifically verifies the fix for Citation serialization issue - Covers to_dict() and json.dumps/loads round-trip serialization - Ensures citation_mappings are properly converted to dicts, not Citation objects - Prevents regression of truncated JSON file issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Citation objects not being JSON serializable, which caused truncated output files and application crashes.
Problem: JobResult.to_dict() used asdict() on Citation objects, causing JSON serialization to fail mid-write.
Solution: Replace asdict() with manual dict conversion for citations and citation_mappings.
✅ Complete job output files
✅ No more truncated JSON
✅ All tests pass