Add save_to_json() convenience method to JobResult #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add simple save_to_json() method that handles Citation serialization automatically - Creates directories as needed and uses existing to_dict() method internally - Updated README.md with usage examples - Added comprehensive test with tmp_path fixture - Minimal code addition (~10 lines) for maximum user convenience Fixes the need for users to manually handle Citation serialization when saving results.
- Remove unused __json__() method from Citation class - Remove unused BatchataJSONEncoder and json_encoder.py file - Clean up utils/__init__.py imports - Revert version back to 0.4.4 (no version bump yet) - Keep minimal, clean save_to_json() implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds save_to_json() method to JobResult for easy JSON saving.
Changes:
Usage:
for result in results['completed']:
result.save_to_json(f'output/{result.job_id}.json')
Benefits: