Fix JSON serialization issue with date fields #36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
JobResult.to_dict()to usemodel_dump(mode='json')for proper serializationProblem
When using Pydantic models with
datefields asresponse_model, the library would fail to save results to JSON files because Python'sjson.dump()cannot serializedateobjects directly. This caused truncated output files and error messages like "Object of type date is not JSON serializable".Solution
Changed
model_dump()tomodel_dump(mode='json')inJobResult.to_dict(), which ensures all fields are JSON-serializable (dates become ISO format strings).Test Plan
No breaking changes