Add lift area to Part #31
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MyraJia
approved these changes
Jan 15, 2023
Collaborator
MyraJia
left a comment
MyraJia
left a comment
There was a problem hiding this comment.
Looks good, the changes seem simple and easy to follow. My main question would be how this information is ultimately consumed by the validation code - would additional work be required to allow users to set limits on lifting area or similar?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to include things like wing loading in the craft evaluator report, the api needs to know about the lifting area defined in the part file (if any). This change extracts lift metadata from uploaded part files and stores it in a new column in the parts table.