update pre-commit hooks #19
Conversation
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the versions of several pre-commit hooks. While keeping dependencies up-to-date is a good practice, several of the specified versions for tools like isort, black, flake8, and clang-format appear to be invalid or correspond to unreleased versions. This will cause pre-commit to fail upon installation or execution. Please review and correct the version numbers to valid, existing releases.
| - id: check-added-large-files | ||
| - repo: https://github.com/pycqa/isort | ||
| rev: 5.12.0 | ||
| rev: 7.0.0 |
There was a problem hiding this comment.
The specified version 7.0.0 for isort does not appear to be a valid release. The latest stable version is 5.13.2. Using a non-existent version will cause pre-commit to fail. Please update this to a valid, existing version.
rev: 5.13.2| args: [--remove-unused-variables] | ||
| - repo: https://github.com/psf/black | ||
| rev: 23.1.0 | ||
| rev: 25.12.0 |
There was a problem hiding this comment.
The specified version 25.12.0 for black is invalid. black uses a calendar-based versioning scheme (YY.MM.MICRO), and this version points to a future date in 2025 and does not exist. The latest stable version is 24.4.2. Using a non-existent version will cause pre-commit to fail. Please update this to a valid, existing version.
rev: 24.4.2| - id: black | ||
| - repo: https://github.com/pycqa/flake8 | ||
| rev: 6.0.0 | ||
| rev: 7.3.0 |
There was a problem hiding this comment.
The specified version 7.3.0 for flake8 does not appear to be a valid released version. The latest stable version is 7.1.0. Using a non-existent version will cause pre-commit to fail. Please update this to a valid, existing version.
rev: 7.1.0| - id: buildifier | ||
| - repo: https://github.com/pre-commit/mirrors-clang-format | ||
| rev: v15.0.7 | ||
| rev: v21.1.8 |
There was a problem hiding this comment.
The specified version v21.1.8 for mirrors-clang-format is invalid. clang-format versions are tied to LLVM releases, and LLVM 21 does not exist. The latest version available in this mirror appears to be v18.1.8. Using an invalid version will cause pre-commit to fail. Please update this to a valid, existing version.
rev: v18.1.8
No description provided.