Skip to content

Conversation

@ravenfeld
Copy link

considers several date formatting

Review on Reviewable

@ahorn
Copy link
Owner

ahorn commented Sep 23, 2013

Use function arguments instead of global variables [1,2]. This makes the code more robust in multi-threaded calling contexts. Please also add test cases that can be executed with "mvn test". See existing test cases.

[1] ravenfeld@e24d4cb#L0R65
[2] ravenfeld@e24d4cb#L0R29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants