-
Notifications
You must be signed in to change notification settings - Fork 1
Return error on empty input instead of panicking #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #281 +/- ##
=======================================
Coverage 13.01% 13.01%
=======================================
Files 7 7
Lines 530 530
=======================================
Hits 69 69
Misses 461 461 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
We need to verify that error handling is working properly. |
|
Hi @kimhanbeom — quick status: PR #281 (Return error on empty input instead of panicking) is ready for review from a CI perspective: all checks passed and modified lines are covered per Codecov, though the project coverage percent dropped. The author noted they will add extra test cases after Issue #274 is merged. There are currently no requested reviewers. Could you please assign a reviewer or let me know if you prefer we wait until the tests tied to #274 are added before requesting review? Thanks! |
0451308 to
004c591
Compare
becec7a to
882c050
Compare
|
@pott-cho Could you review this PR? |
|
@JonghoKim-jj |
|
@pott-cho Thanks. I'll create an issue later (not now). |
882c050 to
fee9406
Compare
Closes #280
I implemented the check inside
to_cert_chain()rather thantry_new().It makes more sense for the parsing function to guarantee a valid (non-empty) chain.