Skip to content

Conversation

@JonghoKim-jj
Copy link
Contributor

Closes #280

I implemented the check inside to_cert_chain() rather than try_new().
It makes more sense for the parsing function to guarantee a valid (non-empty) chain.

@codecov
Copy link

codecov bot commented Jan 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 13.01%. Comparing base (36f5b0d) to head (fee9406).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #281   +/-   ##
=======================================
  Coverage   13.01%   13.01%           
=======================================
  Files           7        7           
  Lines         530      530           
=======================================
  Hits           69       69           
  Misses        461      461           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JonghoKim-jj
Copy link
Contributor Author

We need to verify that error handling is working properly.
I will add test cases after Issue #274 is merged.

@octoaide
Copy link
Contributor

octoaide bot commented Jan 27, 2026

Hi @kimhanbeom — quick status: PR #281 (Return error on empty input instead of panicking) is ready for review from a CI perspective: all checks passed and modified lines are covered per Codecov, though the project coverage percent dropped. The author noted they will add extra test cases after Issue #274 is merged. There are currently no requested reviewers. Could you please assign a reviewer or let me know if you prefer we wait until the tests tied to #274 are added before requesting review? Thanks!

@JonghoKim-jj JonghoKim-jj force-pushed the leo/issue-280-prevent-panic-in-try_new branch from 0451308 to 004c591 Compare January 28, 2026 04:26
@JonghoKim-jj JonghoKim-jj force-pushed the leo/issue-280-prevent-panic-in-try_new branch 2 times, most recently from becec7a to 882c050 Compare January 28, 2026 05:03
@JonghoKim-jj JonghoKim-jj requested a review from pott-cho January 28, 2026 05:03
@JonghoKim-jj
Copy link
Contributor Author

@pott-cho Could you review this PR?

@pott-cho
Copy link
Contributor

@JonghoKim-jj
Overall, this looks good.
However, introducing pretty_assertions only in this PR could slightly reduce consistency by mixing different test styles.
If it’s deemed necessary, how about creating a separate issue to apply it consistently across the entire test suite later?

@JonghoKim-jj
Copy link
Contributor Author

@pott-cho Thanks. I'll create an issue later (not now).
After few PRs adding tests are merged, it will help.

@JonghoKim-jj JonghoKim-jj force-pushed the leo/issue-280-prevent-panic-in-try_new branch from 882c050 to fee9406 Compare January 28, 2026 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prevent panics in Certs::try_new on invalid input

3 participants