-
Notifications
You must be signed in to change notification settings - Fork 8
Fix issue #491: Refactor Network table for global name uniqueness
#653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4e8aa9b to
6b527c8
Compare
|
I resolved the merge conflicts, rebased, and force-pushed the updated branch. I reviewed the PR and determined no further code changes were necessary after resolving conflicts. What I did:
Verification:
Summary: Merge conflicts are resolved, the migration logic and types are reconciled with the PR, and the branch is rebased and pushed with successful build and tests. |
|
I am happy to wait for your review if you are particularly interested in this issue and PR. However, if that is not the case, would you mind assigning a different reviewer, @msk? |
|
Hi @msk — gentle ping for review of this PR that refactors the Network table for global name uniqueness (fixes #491). I previously resolved merge conflicts, rebased, and force-pushed; all CI checks and tests are passing. The branch currently shows mergeable state as dirty, which likely means it just needs an approval or a final maintainer action. Could you take a look when you have a moment? If you're not available to review, @sophie-cluml indicated she's happy to reassign — please say so here and we can assign another reviewer. If there's anything I should change before you review, let me know and I can update the branch. Thanks! |
4f195af to
2ca6b07
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #653 +/- ##
==========================================
+ Coverage 80.90% 81.09% +0.19%
==========================================
Files 83 83
Lines 23358 23501 +143
==========================================
+ Hits 18897 19059 +162
+ Misses 4461 4442 -19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e93bb49 to
fa9ea62
Compare
fa9ea62 to
2371495
Compare
sophie-cluml
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@octoaide, could you do below:
- update
versionin Cargo.toml to0.44.0-alpha.2 COMPATIBLE_VERSION_REQin migration.rs to ">=0.44.0-alpha.2,<0.44.0-alpha.3"- update the last element in
migrationvector from before to after// before ( VersionReq::parse(">=0.43.0,<0.44.0-alpha.1")?, Version::parse("0.44.0-alpha.1")?, migrate_0_43_to_0_44, ), // after ( VersionReq::parse(">=0.43.0,<0.44.0-alpha.2")?, Version::parse("0.44.0-alpha.2")?, migrate_0_43_to_0_44, ),
|
Added a commit for alpha version adjustments myself. |
Summary
Automated changes to address issue #491: Refactor
Networktable for global name uniquenessChanges
6 file(s) modified.
Closes #491
This pull request was automatically created by octoaide.