Skip to content

Conversation

@oeway
Copy link
Collaborator

@oeway oeway commented Jul 3, 2025

Hi @ScientistRachel and @opp1231 while I am still working on this, maybe you can give me some hint on how we should attach source code files? In my case I have some python code to generate data for figures, train models, which is not meant for show to the readers, but they can check in details if needed. In this case can I leave it as some python files? where should place them? also where should I place figures? I have them in a separate folders. Please comment if you see changes needed regarding these.

Content-wise, it's a dump of everything right now, need a bit more work on re-org and polishing, will do with a postdoc in my group.

@ScientistRachel
Copy link
Member

Hi @oeway,

Thank you for the draft PR. Source code files can go in the upper-level notebooks folder of the repo, and your chapter can link to them as a reference. Your assets folder makes sense for your images, and if any of your source code should be less prominent, leaving it there as well is an option.

The draft so far has a lot of interesting information. We suggest expanding the intro paragraphs a bit to give an expanded road map of the chapter. This will be helpful for readers who may know very little about LLMs beyond ChatGPT's existence. We also suggest as you refine the text making sure that terms are well defined for inexperienced readers. We will wait on fully editing the draft until you tell us it is ready for review.

All the best,
Rachel & Owen

@ScientistRachel
Copy link
Member

Hi @oeway,

We wanted to briefly follow up on the status of your draft PR. You had mentioned wanted to work on the draft more before a full review. Please let us know when this draft is ready, and we will be happy to take a look.

Thank you,
Rachel & Owen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants