Skip to content

Fix: Reputationer - predictiveness internals are rounded up to 1 #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
konard wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix: Reputationer - predictiveness internals are rounded up to 1 #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
98ab050
Initial commit with task details for issue #1
konard Oct 9, 2025
c84936d
Fix predictiveness and rating values being incorrectly rounded to int…
konard Oct 9, 2025
cf62803
Remove CLAUDE.md - Claude command completed
konard Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/main/java/net/webstructor/data/Counter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,13 @@ public Linker count(Linker other){
if (other != null)
for (Iterator it = other.keys().iterator(); it.hasNext();){
Object key = it.next();
count(key,round(other.value(key)));
Number value = other.value(key);
// Preserve double values for reputation scores (like predictiveness in range 0.0-1.0)
// Only round integer-like values
if (value instanceof Double || value instanceof Float)
count(key, value.doubleValue());
else
count(key, round(value));
}
return this;
}
Expand Down
3 changes: 1 addition & 2 deletions src/main/java/net/webstructor/peer/Reputationer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,8 +469,7 @@ private int build(Date prevdate, Date nextdate, String[] domains){
sum += r[0];
den += r.length > 1 ? r[1] : 1;
if (params.verbose) env.debug("reputation debug rating: "+rater+" "+ratee+" "+c[j].a+" "+c[j].b+" "+r[0]);
differential.count(ratee, raterValue * Math.round(r[0]), 0);//TODO: no round!?
// differential.count(ratee, Math.round(raterValue * r[0]), 0);//TODO: no round!?
differential.count(ratee, raterValue * r[0], 0);
if (params.denomination && r.length > 1)
normalizer.count(ratee, r[1], 0);
if (params.spendings > 0 && r.length > 1)
Expand Down