Open
Conversation
Owner
|
Thanks, but your code contains a lot of commented code and Laravel specific code as well as changed files not related to the feature. Can you clean up your PR first? |
aimeos
reviewed
Sep 24, 2021
| <div class="upload-wrapper"> | ||
| <div class="upload-view" | ||
| data-title="<?= $enc->html( $this->translate( 'client/code', $attribute->getName() ) ) ?>" | ||
| onclick="document.querySelector('#upload-<?= $enc->attr( $this->productItem->getId() . '-' . $key ) ?>').click()" |
Owner
There was a problem hiding this comment.
No inline JS please because this won't work because of Content Security Policy rules
aimeos
reviewed
Sep 24, 2021
| $fs->writes($filepath, $stream); | ||
| fclose($stream); | ||
| } catch (\Exception $ex) { | ||
| Log::error($ex->getMessage()); |
Owner
There was a problem hiding this comment.
Log::error() is also Laravel specific. Use $this->getContext()->logger()->log() instead
aimeos
reviewed
Sep 24, 2021
| foreach ($entries[$i]['attrcustid'][$attrId] as $file) { | ||
| $filepath = 'basket-upload/' . md5($file->getFilename() . microtime(true)) . '.' . $file->extension(); | ||
| try { | ||
| $stream = fopen($file->getRealPath(), 'r+'); |
Owner
There was a problem hiding this comment.
Please check return value of fopen()
aimeos
reviewed
Sep 24, 2021
|
|
||
|
|
||
| ?> | ||
| <script type="text/javascript"> |
Owner
There was a problem hiding this comment.
Inline JS doesn't work with CSP and must be moved to the JS file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.