Add score threshold option for searching in index#683
Open
basitanees wants to merge 2 commits intodevelopmentfrom
Open
Add score threshold option for searching in index#683basitanees wants to merge 2 commits intodevelopmentfrom
basitanees wants to merge 2 commits intodevelopmentfrom
Conversation
ahmetgunduz
reviewed
Sep 12, 2025
|
|
||
| def search(self, query: str, top_k: int = 10, filters: List[IndexFilter] = []) -> ModelResponse: | ||
| def search( | ||
| self, query: str, top_k: int = 10, filters: List[IndexFilter] = [], score_threshold: float = 0.0 |
Contributor
There was a problem hiding this comment.
Can we add this a filter object?
Operator Larger, Smaller etc and then a value. Add this as a indexFilder
Collaborator
Author
There was a problem hiding this comment.
@ahmetgunduz Coming back to this. IndexFilter is generally meant for metadata filtering, thats why I think, it would make more sense if score_threshold is kept separate? We can give a more meaningful name for this.
Contributor
|
@basitanees Any update here? It has been hanging for a while now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.