Skip to content

Conversation

@YvesLepidus
Copy link
Contributor

Hi, @ajnyga 😃
This PR adapts the plugin to OJS 3.4

YvesLepidus and others added 6 commits March 27, 2024 14:29
Signed-off-by: Yves <yves@lepidus.com.br>
Signed-off-by: Iudi <iudi@lepidus.com.br>
Signed-off-by: Yves <yves@lepidus.com.br>
Signed-off-by: Iudi <iudi@lepidus.com.br>
@ajnyga
Copy link
Owner

ajnyga commented Dec 4, 2024

Hi, sorry for not noticing this before, I did a new release for 3.4 and looking through your pr I think everything is covered.

What I do not know is whether the changes to version.xml are required. In your pr you are removing lazy-load 1 /lazy-load and class OpenGraphPlugin /class. Can you give me some additional details what that means in practice? I was looking at the other plugins in OJS and they seem to still have those lines.

The new version I released also includes metatags in the issue landing page, since that seems to be more commonly shared.

@YvesLepidus
Copy link
Contributor Author

Hi, @ajnyga 😃
The plugins documentation for version 3.4 has a more simplified version.xml compared to the example for version 3.3.
I couldn't find an explanation of these changes in the documentation. So if you want more details, I can ask on PKP Mattermost.

@ajnyga
Copy link
Owner

ajnyga commented Dec 5, 2024

Thanks! That is weird since all the PKP maintained plugins still seem to have those lines there. Of course if they are simply not used it would not matter, so could be just an oversight. I tried to look for a github issue about this as well but no luck.

I asked this in Mattermost just to be sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants