Skip to content

Conversation

@xerion12
Copy link

  • Decide on @astrojs/partytown: configure properly or remove unused.
  • Add developer scripts: check, typecheck, format.
  • Create GitHub Actions workflow for install, build, and checks.
  • Document new scripts in README.

@Fluffy9
Copy link

Fluffy9 commented Nov 2, 2025

The developer scripts you mentioned are not in the package.json

@HoomanDgtl
Copy link
Contributor

hii @xerion0712 , your formatting check would fail in most of the cases as prettier convention is not being followed by the contributors actively:

  • name: Check formatting
    run: npm run format

@xerion12
Copy link
Author

xerion12 commented Nov 3, 2025

thanks for calling this out. I’ve kept formatting visibility in CI but made it non-blocking so it won’t fail builds while still surfacing issues. I also added clear local scripts and can follow up with a pre commit hook to auto-format before commits if you prefer strict enforcement.”

  • what I changed to fix:
    • package.json: added scripts
      • check: astro check
      • typecheck: tsc --noEmit
      • format: prettier --check .
      • format:write: prettier --write .
    • .github/workflows/ci.yml: made the formatting step non-blocking so it reports but doesn’t fail the job:
      • “Check formatting (non-blocking)” runs npm run format with continue-on-error: true

@xerion12
Copy link
Author

xerion12 commented Nov 3, 2025

if you prefer stricter enforcement, i can add Husky + lint staged in a followup so formatting is auto applied before commits and we can make CI strict again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants