Fix missing application of user-agent setting #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One place where the user-agent setting was not applied, resulting in some podcasts failing to download still. Creating a PR to highlight that this was missed as it is only mentioned in a comment on the previous PR. credit to @wiseindy https://github.com/wiseindy/podgrab
fracai
reviewed
Nov 22, 2022
| setting := db.GetOrCreateSetting() | ||
| if len(setting.UserAgent) > 0 { | ||
| req.Header.Add("User-Agent", setting.UserAgent) | ||
| } |
Contributor
There was a problem hiding this comment.
You can just use the existing getRequest method from fileService.go. Replace the call to NewRequest on line 714 with getRequest as in:
req, err := getRequest(url)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional for #214.
One place where the user-agent setting was not applied, resulting in some podcasts failing to download still. Creating a PR to highlight that this was missed as it is only mentioned in a comment on the previous PR.
credit to @wiseindy
https://github.com/wiseindy/podgrab