Fix seq-zip to avoid spurious nils#3
Open
michalmarczyk wants to merge 1 commit intoakhudek:masterfrom
Open
Conversation
Owner
|
Thanks! I'd like to wait for Clojure/core's response as I'd like this library to have matching semantics to clojure's zip (including bugs). Assuming this is included in clojure 1.6, I'll make a new release matching that with appropriate documentation. |
Author
|
Sure, that makes sense. Users can just include this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See CLJ-1317:
http://dev.clojure.org/jira/browse/CLJ-1317
Credit for discovering the problem goes to Lee Spector. More comments on the Clojure ticket.
Note that this is a completely fresh issue, with no comments from Clojure/core on the patch.