Fixed critical bug in PATCH API calls & improved error reporting #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library was unable to make PATCH API calls in line with current Wise API requirements. This prevents is from being able to make serveral API calls in Staging and Prod, including required calls for: https://docs.wise.com/api-docs/api-reference/batch-group payments.
Additionally, the library's error handling was failing on certain API calls, so I make this more robust.
I also added specific error handling for One Time Token reasons: https://docs.wise.com/api-docs/api-reference/one-time-token
I also added the ability to modify the headers that are sent to the Wise API (which was ultimately the issue leading to the failing PATCH requests).
This is all backwards compatible.