-
Notifications
You must be signed in to change notification settings - Fork 174
Games SOLVED #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Games SOLVED #5
Conversation
| while (!validAddress) { | ||
| wallet = ethers.Wallet.createRandom() | ||
| address = await wallet.getAddress() | ||
| if(address < threshold) validAddress = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hope you don't mind me asking, but how does comparing a string (address) with a number (threshold) work here?
I was struggling with this test file as I couldn't figure out how to identify which address would be less than the threshold address; when I convert an address to a number (either with Number(address) or parseInt(address)) I could find an address that was less than the threshold number, but they wouldn't work.
I'm guessing I don't really understand how Hexadecimal numbers work? 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@skplunkerin JS let you compare the numbers just like that, but a better way can be adding an "n" to the threshold, so JS knows this is a bigInt and can compare them more accurately
the If statement can be something like that:
if(BigInt(address) < BigInt(threshold){
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aw, that makes sense. Thanks for replying! I forget that an address is a hexadecimal, and that hexadecimal's are numbers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how long the loop ran?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it was supposed to be ajoke?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@apoorv-2204 I tried several times and it ran between 100-300 times, which took a couple of seconds.
Thanks for the amazing challenges. I solved the games pretty quick as I have some experience with solidity and web3 development in general. I highly recommend solving them for beginners.
Waiting for intermediate level challenges.