Sanitize content hashes in archive methods#175
Open
tillprochaska wants to merge 2 commits intomainfrom
Open
Conversation
tillprochaska
force-pushed
the
fix/validate-content-hash
branch
from
07bea7b to
e37a8dd
Compare
tillprochaska
commented
May 29, 2024
Contributor
Author
There was a problem hiding this comment.
Content hash also needes to be sanitized for the generate_url!
Contributor
There was a problem hiding this comment.
- sanitize hashes in generate_url calls
tillprochaska
commented
May 29, 2024
Contributor
Author
There was a problem hiding this comment.
Content hash needs to be sanitized for the generate_url method as well!
Contributor
Author
|
Probably need to also sanitize prefixes as well (e.g. in the |
catileptic
approved these changes
Jun 18, 2024
Contributor
catileptic
left a comment
catileptic
left a comment
There was a problem hiding this comment.
Seems good to me. We can merge this after the remaining comments are addressed :)
Our content hashes are always hex digests and we should reject anything that contains non-hex characters.
stchris
force-pushed
the
fix/validate-content-hash
branch
from
0f9e719 to
aeed179
Compare
Contributor
|
Thanks for this PR, @tillprochaska and sorry it took so long to finish it. I just added two more calls from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our content hashes are always hex digests and we should reject anything that contains non-hex characters. This raises an exception when trying to call archive methods with invalid content hashes.
You can test this in Aleph by installing serivcelayer from this branch:
Don’t forget to restart the
apicontainer after doing this :)