Skip to content

Fix seed id generation #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cveilleux wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix seed id generation #104

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b65c79c
perf: Use a set instead of a list to keep track of in-flight seed ids.
cveilleux Mar 24, 2023
fe9eb13
fix: Clean-up seed_id from in-flight set of SEED_IDs using a try/fina…
cveilleux Mar 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions pythonping/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@


# this needs to be available across all thread usages and will hold ints
SEED_IDs = []
SEED_IDs = set()


def ping(target,
Expand Down Expand Up @@ -74,15 +74,16 @@ def ping(target,
# seed_id needs to be less than or equal to 65535 (as original code was seed_id = getpid() & 0xFFFF)
seed_id = randint(0x1, 0xFFFF)
if seed_id not in SEED_IDs:
SEED_IDs.append(seed_id)
SEED_IDs.add(seed_id)
break

try:
comm = executor.Communicator(target, provider, timeout, interval, socket_options=options, verbose=verbose, output=out,
seed_id=seed_id, source=source, repr_format=out_format)

comm = executor.Communicator(target, provider, timeout, interval, socket_options=options, verbose=verbose, output=out,
seed_id=seed_id, source=source, repr_format=out_format)
comm.run(match_payloads=match)

comm.run(match_payloads=match)

SEED_IDs.remove(seed_id)
finally:
SEED_IDs.remove(seed_id)

return comm.responses